Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands
From: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 15 Oct 2018 10:04:27 +1100 (AEDT)
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <4719e984-2c7e-33e1-6e7c-16dea5d4f610@gmail.com>
References: <cover.1539497520.git.fthain@telegraphics.com.au> <91b9ff9fc19ba40e3a2562171c8cd78a2ce7dc79.1539497520.git.fthain@telegraphics.com.au> <20181014154753.GA19252@infradead.org> <4719e984-2c7e-33e1-6e7c-16dea5d4f610@gmail.com>

On Mon, 15 Oct 2018, Michael Schmitz wrote:


Do we really need to make that distinction?


esp_reconnect() dereferences lp, so !lp has to inhibit disconnection.

At least, that's my reading. I can't see any other reason for the lp 
conditional.

--

References:
- [PATCH v2 0/6] mac_esp, zorro_esp, esp_scsi: Various improvements
  - From: Finn Thain
- [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands
  - From: Finn Thain
- Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands
  - From: Christoph Hellwig
- Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands
  - From: Michael Schmitz

Prev by Date: Re: [PATCH v2 2/6] esp_scsi: Track residual for PIO transfers
Next by Date: Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands
Previous by thread: Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands
Next by thread: Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands
Index(es):
- Date
- Thread

[Index of Archives] [Video for Linux] [Yosemite News] [Linux S/390] [Linux Kernel] [Linux SCSI]