On Wed, 20 Jun 2018, Christoph Hellwig wrote:
When this was posted for the last merge window Finn Thain reported this works, but requires further dma mask fixes in m68 driver.
The dma mask fix was actually needed because of the WARN_ON that appeared in v4.16, due to commit 205e1b7f51e4 ("dma-mapping: warn when there is no coherent_dma_mask"). The dma mask fix is commit b12c8a70643f ("m68k: Set default dma mask for platform devices"). The generic dma code failed catastrophically without the mask fix, but you resolved that with commit 2550bbfd4952 ("dma-direct: don't crash on device without dma_mask"). The generic dma code threw up a warning with CONFIG_DMA_API_DEBUG=y that was fixed in commit 26de0b76d9ba ("net/sonic: Use dma_mapping_error()").
It would be great if this patch could be queued up for 4.19 together with said fixes.
Looks like all of the above-mentioned commits are in mainline so there should be no problem queueing this up (as far as Mac/68k drivers are concerned). -- -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html