Re: [PATCH v3 1/4] dmaengine: fsl-edma: add config and makefile changes for mcf-edma

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Angelo,

On Tue, Jun 12, 2018 at 6:35 PM Angelo Dureghello <angelo@xxxxxxxx> wrote:
> This patch adds Kconfig and makefile changes to add ColdFire
> mcf5441x family edma support.
> A new fsl-edma-common module has been added, to collect common
> code to fsl-edma.
>
> Signed-off-by: Angelo Dureghello <angelo@xxxxxxxx>
> ---
> Changes for v2:
> - patch splitted into 4
> - add fsl-edma-common
>
> Changes for v3:
> - remove Kconfig FSL_EDMA_COMMON and set fsl-edma-common.o as
>   additional object entry where needed.

> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig

> @@ -327,6 +328,18 @@ config LPC18XX_DMAMUX
>           Enable support for DMA on NXP LPC18xx/43xx platforms
>           with PL080 and multiplexed DMA request lines.
>
> +config MCF_EDMA
> +       tristate "Freescale eDMA engine support, ColdFire mcf5441x SoCs"
> +       depends on M5441x
> +       select DMA_ENGINE
> +       select DMA_VIRTUAL_CHANNELS
> +       select FSL_EDMA_COMMON
> +       help
> +         Support the Freescale ColdFire eDMA engine, 64-channel
> +         implementation that performs complex data transfers with
> +         minimal intervention from a host processor.
> +         This module can be found on Freescale ColdFire mcf5441x SoCs.

I think MCF_EDMA should be added in patch 4/4 only.

> +
>  config MMP_PDMA
>         bool "MMP PDMA support"
>         depends on ARCH_MMP || ARCH_PXA || COMPILE_TEST
> diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
> index 0f62a4d49aab..cce5e3400580 100644
> --- a/drivers/dma/Makefile
> +++ b/drivers/dma/Makefile
> @@ -32,7 +32,8 @@ obj-$(CONFIG_DW_AXI_DMAC) += dw-axi-dmac/
>  obj-$(CONFIG_DW_DMAC_CORE) += dw/
>  obj-$(CONFIG_EP93XX_DMA) += ep93xx_dma.o
>  obj-$(CONFIG_FSL_DMA) += fsldma.o
> -obj-$(CONFIG_FSL_EDMA) += fsl-edma.o
> +obj-$(CONFIG_FSL_EDMA) += fsl-edma.o fsl-edma-common.o
> +obj-$(CONFIG_MCF_EDMA) += mcf-edma.o fsl-edma-common.o

Same for the line above: without patch 4/4, it won't build.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html