Re: [parted-devel] [PATCH] Fix atari label false positives

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/5/2018 4:08 PM, Håkon Løvdal wrote:
While the commit message contains the relevant information, this really
ought to be present as a comment directly in the code as well. And
the un-obviousness of the code vs check order deserves a mention as
well, so please add a commen like

+       ped_disk_atari_init (); // NB! Must be first so that it is checked last.

Will do.

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux