Re: [PATCH v2 1/4] dmaengine: fsl-edma: add config and makefile changes for mcf-edma

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,
On Wed, Jun 06, 2018 at 09:21:33AM +0200, Geert Uytterhoeven wrote:
Hi Angelo,

On Tue, Jun 5, 2018 at 11:45 PM, Angelo Dureghello <angelo@xxxxxxxx> wrote:
This patch adds Kconfig and makefile changes to add ColdFire
mcf5441x family edma support.
A new fsl-edma-common module has been added, to collect common
code to fsl-edma.

Signed-off-by: Angelo Dureghello <angelo@xxxxxxxx>

Thanks for your patch!

--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -220,11 +220,17 @@ config FSL_EDMA
        depends on OF
        select DMA_ENGINE
        select DMA_VIRTUAL_CHANNELS
+       select FSL_EDMA_COMMON
        help
          Support the Freescale eDMA engine with programmable channel
          multiplexing capability for DMA request sources(slot).
          This module can be found on Freescale Vybrid and LS-1 SoCs.

+config FSL_EDMA_COMMON
+       bool
+       depends on FSL_EDMA || MCF_EDMA
+       default n

If this symbol is used only for controlling the build of a source file, then
you don't really need it...

+
 config FSL_RAID
         tristate "Freescale RAID engine Support"
         depends on FSL_SOC && !ASYNC_TX_ENABLE_CHANNEL_SWITCH
@@ -327,6 +333,18 @@ config LPC18XX_DMAMUX
          Enable support for DMA on NXP LPC18xx/43xx platforms
          with PL080 and multiplexed DMA request lines.

+config MCF_EDMA
+       tristate "Freescale eDMA engine support, ColdFire mcf5441x SoCs"
+       depends on M5441x
+       select DMA_ENGINE
+       select DMA_VIRTUAL_CHANNELS
+       select FSL_EDMA_COMMON
+       help
+         Support the Freescale ColdFire eDMA engine, 64-channel
+         implementation that performs complex data transfers with
+         minimal intervention from a host processor.
+         This module can be found on Freescale ColdFire mcf5441x SoCs.
+
 config MMP_PDMA
        bool "MMP PDMA support"
        depends on ARCH_MMP || ARCH_PXA || COMPILE_TEST
diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
index 0f62a4d49aab..823a590f308b 100644
--- a/drivers/dma/Makefile
+++ b/drivers/dma/Makefile
@@ -33,6 +33,8 @@ obj-$(CONFIG_DW_DMAC_CORE) += dw/
 obj-$(CONFIG_EP93XX_DMA) += ep93xx_dma.o
 obj-$(CONFIG_FSL_DMA) += fsldma.o
 obj-$(CONFIG_FSL_EDMA) += fsl-edma.o
+obj-$(CONFIG_FSL_EDMA_COMMON) += fsl-edma-common.o
+obj-$(CONFIG_MCF_EDMA) += mcf-edma.o

... as you can just write in the Makefile:

    obj-$(CONFIG_FSL_EDMA) += fsl-edma.o fsl-edma-common.o
    obj-$(CONFIG_MCF_EDMA) += mcf-edma.o fsl-edma-common.o

many thanks, will do that.

 obj-$(CONFIG_FSL_RAID) += fsl_raid.o
 obj-$(CONFIG_HSU_DMA) += hsu/
 obj-$(CONFIG_IMG_MDC_DMA) += img-mdc-dma.o

Gr{oetje,eeting}s,

                        Geert


Regards,
Angelo

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux