Re: [PATCH v6] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Finn,

Am 07.04.2018 um 22:19 schrieb Finn Thain:
On Sat, 7 Apr 2018, Michael Schmitz wrote:


  CHECK   /home/fthain/src/kernel.org/linux/drivers/scsi/zorro_esp.c
drivers/scsi/zorro_esp.c:274:14: warning: cast removes address space of expression
drivers/scsi/zorro_esp.c:712:14: warning: cast removes address space of expression

Why not just call writel() and get rid of the 't' temporary pointer?

As far as I can see, that will invoke cpu_to_le32() on the data written.

Good point.

Since this is zorro card driver, why not use z_writel()?

Equally good point - that's what it's there for.

Cheers,

	Michael


--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux