On Sun, 11 Mar 2018, Michael Schmitz wrote:
Still to do: - avoid BUG_ON() in DMA setup. In order to downgrade tp WARN_ON(), I need to verify dma_error=1 will completely abort the affected command and run error recivery. Can anyone confirm this?
I think you can omit all of those BUG_ON statements, and I did so in mac_esp.c, because AFAICT there is no situation where the core driver might fail to set the ESP_CMD_DMA bit. Of course, if you are working on the core driver itself, this kind of assertion might be useful. But even then you wouldn't want it in ten places in six different wrapper drivers. -- -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
