Re: [RFC] m68k: Fix dead code in bus_error030()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Geert,

the crash was introduced after Finn re-livened the dead code (and
thereby bypassed exception table fix-up AFAICS).

Cheers,

	Michael


Am 09.03.2018 um 21:12 schrieb Geert Uytterhoeven:
Hi Finn,

On Fri, Mar 9, 2018 at 8:13 AM, Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
On Fri, 9 Mar 2018, Michael Schmitz wrote:
I think I can find a solution for that. The main reason for this RFC is a
bunch of question I can't answer:

- What are the implications of the existing logic error?

- What was the author trying to achieve? Why a special case for RMW
  faults?

- How much latitude is there to change this without breaking weird
  platforms?

That's my biggest worry for now.

- Should the dead code be deleted because the live algorithm cannot be
  improved upon? (The present algorithm works fine for PDMA for example.)

If it introduced a crash, it is not dead code?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux