On Sat, Mar 3, 2018 at 12:08 AM, Christoph Hellwig <hch@xxxxxx> wrote:
Assuming all zorro devices can deal fine with a 32-bit dma mask:
No they don't. Zorro II has a 24-bit bus, Zorro III has a 32-bit bus.
So it should be something like:
switch (z->rom.er_Type & ERT_TYPEMASK) {
case ERT_ZORROIII:
z->dev.coherent_dma_mask = DMA_BIT_MASK(32);
break;
case ERT_ZORROII:
default:
z->dev.coherent_dma_mask = DMA_BIT_MASK(24);
break;
}
Other types are not defined, but I have no idea how expansion boards for
the original Amiga 1000 ("Zorro I") are represented. As that one had a 24-bit
bus, using 24 for the default should be fine.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
