Hi Finn, On Sat, Nov 11, 2017 at 7:12 AM, Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
Create the /proc/bus/nubus/s/ inodes while scanning slot s. During descent through slot resource subdirectories, call the new nubus_proc_add_foo() functions to create the procfs inodes. Also add a new function, nubus_seq_write_rsrc_mem(), to write the contents of a particular slot resource to a given seq_file. This is used by the procfs file_operations methods, to finally give userspace access to slot ROM information, such as the available video modes. Tested-by: Stan Johnson <userm57@xxxxxxxxx> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
Thanks for your patch!
--- drivers/nubus/nubus.c | 117 +++++++++++++++++++++++++++------- drivers/nubus/proc.c | 170 +++++++++++++++++++++++++++++++++++++++++++++++--- include/linux/nubus.h | 35 ++++++++++- 3 files changed, 288 insertions(+), 34 deletions(-)
Wow, that's much more code added than was removed by "[PATCH 10/14] nubus: Depopulate /proc/bus/nubus/s/": drivers/nubus/proc.c | 100 -------------------------------------------------- include/linux/nubus.h | 1 - 2 files changed, 101 deletions(-) How much memory is saved by not using the stored representation of slot resource data? BTW, should 10 and 11 be combined, to avoid a regression during bisection? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html