On Sat, 11 Nov 2017, Joe Perches wrote:
On Sat, 2017-11-11 at 01:12 -0500, Finn Thain wrote:
Testing shows that a single Radius PrecisionColor 24X display board,
which has 95 functional resources, produces over a thousand lines of
log messages. Suppress these messages with pr_debug().
Remove some redundant messages relating to nubus_get_subdir() calls.
Fix the format block debug messages which has the sequence of entries
backwards (my bad).
Move the "Scanning slots" message to its proper location.
pr_debug calls are compiled completely away to nothing
unless DEBUG is
defined or CONFIG_DYNAMIC_DEBUG is
enabled.
Aren't some of these actually useful?
No, not AFAIK. Was there anything in particular that you wanted to see in
the log?
Perhaps it'd be nicer to have some nubus
specific flag to enable these outputs instead
of relying on either #define DEBUG or
CONFIG_DYNAMIC_DEBUG?
The file /proc/nubus has the important info. These patches don't affect
that. For example,
# cat /proc/nubus
Nubus devices found:
Slot E: Farallon EtherMac LC-TP
#
I think that the driver probe log messages have the other facts that are
of interest. (Please refer to the network driver patch series I sent.) For
example,
mac8390 slot.E: Memory length resource not found, probing
mac8390 slot.E: Farallon EtherMac LC-TP (type farallon)
mac8390 slot.E: MAC 00:00:c5:43:36:11, IRQ 61, 32 KB shared memory at 0xfeed0000, 32-bit access.
Thanks for your review.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
