Re: [PATCH] input: misc: don't build m68kspkr when mach_beep is undefined

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert, Dmitry, Alexandre,

On 29/08/17 03:15, Geert Uytterhoeven wrote:
On Mon, Aug 28, 2017 at 6:50 PM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
On Thu, Aug 24, 2017 at 04:44:27PM +0200, Alexandre Belloni wrote:
mach_beep is defined arch/m68k/kernel/setup_mm.c which is compiled only
when MMU is selected.

To avoid linking errors, make INPUT_M68K_BEEP depend on MMU.

Hmm, can we maybe pull mach_beep from setup_mm.c to setup.c? MMU

Sounds OK to me. Greg?

Yeah, I have no problem with that.

At the moment though setup.c is a basic stub with only this in it:

    #ifdef CONFIG_MMU
    #include "setup_mm.c"
    #else
    #include "setup_no.c"
    #endif

It is one of the very few files remaining that we have not fully
re-merged from the original MMU and no-MMU versions.

Maybe its time we looked at cleaning this up as well...

Regards
Greg



dependency seems to be artificial.

That's indeed artificial, it's really a platform dependency.
But currently these platforms (Amiga and Atari) do not support mmu-less
operation (yet).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds


--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux