Re: [PATCH v2 7/7] uapi: export all headers under uapi directories

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 12/01/2017 à 17:28, Jan Engelhardt a écrit :
On Thursday 2017-01-12 16:52, Nicolas Dichtel wrote:

Le 09/01/2017 à 13:56, Christoph Hellwig a écrit :
On Fri, Jan 06, 2017 at 10:43:59AM +0100, Nicolas Dichtel wrote:
Regularly, when a new header is created in include/uapi/, the developer
forgets to add it in the corresponding Kbuild file. This error is usually
detected after the release is out.

In fact, all headers under uapi directories should be exported, thus it's
useless to have an exhaustive list.

After this patch, the following files, which were not exported, are now
exported (with make headers_install_all):

... snip ...

linux/genwqe/.install
linux/genwqe/..install.cmd
linux/cifs/.install
linux/cifs/..install.cmd

I'm pretty sure these should not be exported!

Those files are created in every directory:
$ find usr/include/ -name '\.\.install.cmd' | wc -l
71

That still does not mean they should be exported.

Anything but headers (and directories as a skeleton structure) is maximally suspicious.

What I was trying to say is that I export those directories like other are.
Removing those files is not related to that series.


Regards,
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux