Re: [PATCH 1/3] m68k/mac: Improve NMI handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Finn,

On Tue, Jan 3, 2017 at 5:31 AM, Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
On Mon, 2 Jan 2017, Geert Uytterhoeven wrote:

-/*
- * console_loglevel determines NMI handler function
- */
+extern void show_registers(struct pt_regs *);

Seems like we do have a declaration in ... <linux/kprobes.h>.

Yes, and it would have to be moved outside of the #ifdef CONFIG_KPROBES
portion before it could be used by m68k, openrisc, cris or mn10300, which
all lack HAVE_KPROBES.

Right, seems my manual cpp made a mistake here. It's indeed inside.

Or we could just leave the patch as it is, because thus far m68k has no
need for any declaration except a sole call site in macints.c.

Fine for me. Sorry for the noise.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux