Re: [PATCH] m68knommu: clean up uClinux boot log output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert, Andreas,

On 10/09/16 00:45, Geert Uytterhoeven wrote:
Hi Andreas,

On Fri, Sep 9, 2016 at 4:20 PM, Andreas Schwab <schwab@xxxxxxxxxxxxxx> wrote:
On Sep 09 2016, Greg Ungerer <gerg@xxxxxxxxxxxxxx> wrote:

diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
index 72d272e..a160695 100644
--- a/arch/m68k/kernel/setup_no.c
+++ b/arch/m68k/kernel/setup_no.c
@@ -106,7 +106,7 @@ void __init setup_arch(char **cmdline_p)
      process_uboot_commandline(&command_line[0], sizeof(command_line));
 #endif /* CONFIG_UBOOT */

-     printk(KERN_INFO "\x0F\r\n\nuClinux/" CPU_NAME "\n");

Do you have any idea what's the significance of ^O here?

You raised my interest, too ;-)

http://mailman.uclinux.org/pipermail/uclinux-dev//2003-March/016122.html

The problem with the reasoning there is that this is not the
first string printed. This is what the boot console looks like
now:

Linux version 4.8.0-rc5-00014-g5594b01-dirty (gerg@goober) (gcc version 5.4.0 (GCC) ) #2 Sat Sep 10 14:44:55 AEST 2016


    uClinux/COLDFIRE(m520x)
    COLDFIRE port done by Greg Ungerer, gerg@xxxxxxxxxxxx
    Flat model support (C) 1998,1999 Kenneth Albanowski, D. Jeff Dionne
Built 1 zonelists in Zone order, mobility grouping off. Total pages: 4080
    Kernel command line: root=/dev/mtdblock0
    PID hash table entries: 128 (order: -4, 512 bytes)
    Dentry cache hash table entries: 4096 (order: 1, 16384 bytes)
    ....

So you end up with 2 blank lines for no good reason.

And then there is the question of whether CTRL-O is in any way
useful here. I would argue that it is of pretty much no value
these days - if it ever was:

https://en.wikipedia.org/wiki/Shift_Out_and_Shift_In_characters

Regards
Greg

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux