Re: [PATCH] m68k: use conventional function parameters for do_sigreturn

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 09/02/16 19:48, Andreas Schwab wrote:
Greg Ungerer <gerg@xxxxxxxxxxx> writes:

Should I submit a gcc bug report?

No, it's not a bug.  Function parameters are dead after return, so any
writes to them can be elided.

Given the original code is:

  asmlinkage int do_sigreturn(unsigned long __unused)
  {
        struct switch_stack *sw = (struct switch_stack *) &__unused;
        struct pt_regs *regs = (struct pt_regs *) (sw + 1);

So gcc is determining that what sw and regs points to are
part of do_sigreturn() parameters here?

Given the ugliness of this grunging around in the stack I
still think my original patch to use correct pointer args is
much cleaner all round.

Regards
Greg
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux