Re: [PATCH] m68k: fix build failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 10, 2016 at 10:37 AM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
On Sun, Jan 10, 2016 at 10:35 AM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
On Mon, Jan 4, 2016 at 11:57 AM, Sudip Mukherjee
<sudipm.mukherjee@xxxxxxxxx> wrote:
The defconfig build of m68k was failing with the error:
implicit declaration of function '__pfn_to_phys'

Other architectures have added <asm/memory.h>, but if we do so here then
we will also get redeclaration of some other functions. So it is better
to copy these macros into page_mm.h.

Fixes: 0a3c3bf11240 ("x86, mm: introduce vmem_altmap to augment vmemmap_populate()")
Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>

Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Or should I take this through the m68k tree? It's getting a bit late for
adding new v4.5 stuff...

I see it's already in mm.

I would like to withdraw my Acked-by.

I'm gonna apply it to page.h instead of page_mm.h, to cover the nommu
case, and will queue for v4.5.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux