Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2015-12-23 at 11:56 +1100, Finn Thain wrote:
On Tue, 22 Dec 2015, Joe Perches wrote:

On Tue, 2015-12-22 at 12:18 +1100, Finn Thain wrote:
This patch is just the result of two substitutions. The first removes 
any tabs and spaces at the end of the line. The second replaces runs 
of tabs and spaces at the beginning of comment lines with a single 
space.
 
I think the second of these isn't done well.

The aim of this patch is not to fix code style, but to make it possible to 
compare these two files so that the fork can be repaired. Regexp is very 
helpful in creating uniformity (and a minimal diff).

If this was a coding style issue, we would be discussing the use of 
kernel-doc format for the affected comments, not whitespace.

Many of these comments post reformatting are
much worse to read because of lost alignment.

You exaggerate a very trivial point.

<shrug>

I prefer that all patches be improvements.

I admit that a small proportion of comments are slightly less readable. 
But it is the diff that needs to be readable in order to resolve the fork.

diff -w works well.

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux