Re: [PATCH] m68k: Wire up bpf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 22, 2014 at 12:48 AM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
        Hi Alexei,

On Tue, 21 Oct 2014, Alexei Starovoitov wrote:
On Tue, Oct 21, 2014 at 10:30 AM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
---
 arch/m68k/include/asm/unistd.h      | 2 +-
 arch/m68k/include/uapi/asm/unistd.h | 1 +
 arch/m68k/kernel/syscalltable.S     | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

did the tests pass in samples/bpf/test_verifier ?

Thanks for reminding me about the existence of the tests ;-)

Yes, they passed.

Great, then:
Acked-by: Alexei Starovoitov <ast@xxxxxxxxxxxx>

Note that gcc 4.1.2 doesn't like C99-initialization of anonymous
struct and union members, so I had to use the patch below:

diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
index d18316f9e9c488b0..6ec5060a6ece8f23 100644
--- a/include/uapi/linux/bpf.h
+++ b/include/uapi/linux/bpf.h
@@ -123,7 +123,7 @@ union bpf_attr {
                __u32   key_size;       /* size of key in bytes */
                __u32   value_size;     /* size of value in bytes */
                __u32   max_entries;    /* max number of entries in a map */
-       };
+       } create;

I've tested this stuff with 4.2 and up, since that's the oldest we
have in kernel.org cross-compilers repo.
4.1 was a first release with brand new C front-end which had
all sorts of gotchas and just like 4.0 was a massive release too.
Nowadays I wouldn't touch anything below 4.4
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux