Re: [PATCH RESEND 3/4] m68k/mvme16x: adopt common boot console

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Finn,

On Fri, Apr 11, 2014 at 7:28 AM, Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
In a multi-platform kernel binary we only need one early console instance.
The difficulty here is that the common early console gets started by
early_param(), whereas the MVME16x instance would be started later by
config_mvme16x(). That means some interrupt setup must be done earlier.

Thanks!

--- linux-m68k.orig/arch/m68k/kernel/early_printk.c     2014-03-03 10:29:59.000000000 +1100
+++ linux-m68k/arch/m68k/kernel/early_printk.c  2014-03-03 10:30:01.000000000 +1100

+#ifdef CONFIG_MVME16X
+static struct console early_console_instance = {
+#else
 static struct console early_console_instance __initdata = {
+#endif

+       if (MACH_IS_MVME16x)
+               early_console_instance.write = mvme16x_cons_write;
+       else
+               early_console_instance.write = debug_cons_write;

+       if (!early_console || MACH_IS_MVME16x)
                return 0;

I don't like these tests for MVME16X in (presumably) generic code.
Is there a way we can avoid this?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux