Re: [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2014-03-18 at 14:13 +0100, Geert Uytterhoeven wrote:
no_printk keeps all side effects like
performing any function calls made by the
statement or accessing any volatiles.
That's true...
Using
do { if (0) no_printk(fmt, ##__VA_ARGS__); } while (0)
does not have any side-effects.
... but all current users in include/ have the side-effects.

I believe that's intentional, but <shrug>.

I prefer debug statements to have _no_
side effects when not compiled-in/enabled.

Opinions vary.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux