From: Michael Schmitz <schmitzmic@xxxxxxxxx>
Date: Thu, 6 Mar 2014 19:47:06 +1300
Thanks Dave,
On m68k, host->get_lock is used to both lock and register the
interrupt
that the IDE host shares with other device drivers. Registering the
IDE interrupt handler in ide-probe.c results in duplicating the
interrupt registered (once via host->get lock, and also via
init_irq()),
and may result in IDE accepting interrupts even when another driver
has
locked the interrupt hardware. This opens the whole locking scheme up
to races.
host->get_lock is set on m68k only, so other drivers' behaviour is not
changed.
Signed-off-by: Michael Schmitz <schmitz@xxxxxxxxxx>
It's a bit kludgy, but minimal and correct.
Would you have preferred to use a host flag instead?
I looked into that, we are out of host flags. We'd either need to expand
the flags value to 64-bits or add another u32.
That's overkill for this.
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
