On Tue, Feb 18, 2014 at 3:45 AM, Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
On Mon, 17 Feb 2014, Geert Uytterhoeven wrote:
On Sat, Feb 15, 2014 at 5:47 AM, Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
--- linux-m68k.orig/arch/m68k/Kconfig.debug 2014-02-15 14:49:18.000000000 +1100
+++ linux-m68k/arch/m68k/Kconfig.debug 2014-02-15 15:06:30.000000000 +1100
@@ -12,12 +12,15 @@ config BOOTPARAM_STRING
config EARLY_PRINTK
bool "Early printk"
- depends on MVME16x || MAC
This should depend on !SUN3, as arch/m68k/kernel/sun3-head.S doesn't
have debug_cons_write:
arch/m68k/kernel/built-in.o: In function `early_cons_write':
early_printk.c:(.init.text+0x512): undefined reference to `debug_cons_write'
Alternatively, we can have a loop around prom_putchar() here in the
#ifdef CONFIG_SUN3 case?
Why not?
I just noticed that there's another debug console in arch/m68k/sun3x/prom.c
We have several of these "debug=" consoles.
We could replace that one too (as with MVME16x), assuming someone can test
the changes.
Yes, getting test coverage is the tricky part here.
Or we could just do,
config EARLY_PRINTK
bool "Early printk"
- depends on MVME16x || MAC
+ depends on !SUN3 && !SUN3X
I guess !SUN3 && !SUN3X is correct for this patch anyway; any work on the
other platforms I will put into subsequent patches in the same series.
Sun 3x uses plain head.S, which has a Sun 3x-specific section in serial_putc(),
so there it should work.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
