Re: [PATCH] m68k/mac: Make SCC reset work more reliably

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Finn,

On Sun, Jan 12, 2014 at 2:56 PM, Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
For SCC initialization we cannot assume that the control register is in
the correct state to accept a register pointer. So first read from the
control register in order to "sync" up.

Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>

Thaks for your patch!

---

This patch fixes a boot failure (presumably caused by unhandled SCC
interrupt) on PowerBook 180 with CONFIG_EARLY_PRINTK and with the
bootloader not configured to wake up the serial ports. AFAIK this happens
only on PowerBooks. Even with this fix, Penguin still has to wake the
serial ports or else they don't function on PowerBooks like this one.

IMHO the above should be part of the patch description (i.e. above the
three dashes), as it contains valuable information. Is that OK for you?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux