nfeth and non-zero m68k_memoffset (was: Re: m68k discontigmem bug)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 15, 2013 at 9:15 PM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
P.S.2. There still seems to be a virt/phys mismatch in the NatFeat code too,
       as nfeth doesn't work when m68k_memoffset is non-zero.

Background: As NatFeat calls use physical addresses, all kernel
virtual addresses
passed must be converted to physical addresses using virt_to_phys().

However, nfeth still doesn't work, as XIF_GET_MAC returns 0 if
m68k_memoffset is non-zero.

Interestingly, when dropping the virt_to_phys() on the MAC address buffer,
it does return 1, but the MAC address is not written to the buffer, and thus
contains the stack garbage that was there before.
But now the network works (with a bogus MAC address)!

XIF_GET_IPHOST and XIF_GET_IPATARI return 11 (the correct strlen() of
the IP address), but there's nothing written in the buffer (it's unmodified).
Dropping the virt_to_phys() here makes it fail (return 0). All of this
is harmless,
as the results are printed only.

This is on aranym 0.9.13-1.1 from Ubuntu 12.04 LTS.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux