Re: I/O macros redefined, inconsistent across m68k machdep headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thorsten,
I *really* dislike seeing messages like this while compiling,
that’s why I’m sending them there. I had a look at both files,
but there’s a lot of ifdeffery going on, and I don’t know
which of the macro resolutions, if any, is supposedly correct.
I'm responsible for part of the ifdef'ery in io_mm.h - as far as I can see, Q40 only needs this hack for the parport, all other ISA accesses should be mapped to isa_insl()/isa_outsl() with address translation applied correctly in all cases regarding of whether or not this is a multiarch kernel.

I'm certain there is a reason for turning the word macros into byte ones (Q40 needs delays between accesses, maybe that's it. Or the parport chip is 8 bit only). So this most likely needs to stay.

A cleaner way to do this would be to prefix the #defines with

#ifdef isa_insl
#undef isa_insl
#undef isa_outsl
#endif

(untested)

or just #undef anyway, since we can be fairly certain the previous #defines have been made.
  CC [M]  drivers/parport/parport_pc.o
In file included from /tmp/buildd/linux-3.8.12/drivers/parport/
parport_pc.c:67:0:
/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:14:0: warning: "insl" redefined [enabled by default] /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:280:0: note: this is the location of the previous definition /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:15:0: warning: "outsl" redefined [enabled by default] /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0: note: this is the location of the previous definition
In file included from /tmp/buildd/linux-3.8.12/drivers/parport/
parport_pc.c:67:0:
/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:14:0: warning: "insl" redefined [enabled by default] /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:280:0: note: this is the location of the previous definition /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:15:0: warning: "outsl" redefined [enabled by default] /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0:this is the location of the previous definition


This is from building the amiga flavour (first of six!) of the Debian
unstable Linux kernel source package. We’ll have the new kernels in
roughly 1½-2 weeks, if everything works ☺
What kernel versions are these?

Cheers,

   Michael

bye,
//mirabilos

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux