Hi Geert,
#define ATARI_ETHERNEC_PHYS_ADDR 0xfffa0000 #define ATARI_ETHERNEC_BASE 0x300 #define ATARI_ETHERNEC_IRQ IRQ_MFP_TIMER1 @@ -716,8 +791,66 @@ static struct platform_device rtl8019_device = { .resource = rtl8019_resources, }; -static struct platform_device *atari_ethernec_devices[] __initdata = { - &rtl8019_deviceOops, removal of atari_ethernec_devices?
Superseded by atari_netusbee_devices which holds both ethernet and usb platform data:
+static struct platform_device *atari_netusbee_devices[] __initdata = { + &rtl8019_device, + &netusbee_device }; int __init atari_platform_init(void) @@ -739,7 +872,7 @@ int __init atari_platform_init(void) #if IS_ENABLED(CONFIG_ATARI_ETHERNEC) enec_virt = (unsigned char *)ioremap((ATARI_ETHERNEC_PHYS_ADDR), 0xf); if (hwreg_present(enec_virt)) { - rv2 = platform_add_devices(atari_ethernec_devices, ARRAY_SIZE(atari_ethernec_devices)); + rv2 = platform_add_devices(atari_netusbee_devices, ARRAY_SIZE(atari_netusbee_devices));Oops, removal of atari_ethernec_devices?
The USB driver does the Right Thing (tm) when probing a nonexisting NetUSBee (amazing, isn't it?) so we can always add both devices regardless of configuration. I'll have to check that CONFIG_ATARI_ETHERNEC is selected when either ne.c or isp116x driver are selected. It might otherwise be possible to select the USB driver only, and not the ethernet one, resulting in a nonfunctional driver. Cheers, Michael -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
