Re: [PATCH 1/4 V2] Add linux/io.h to make m54xx_wdt.c compile with MMU enabled.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stany,

On 16/10/12 00:08, Stany MARCEL wrote:
Signed-off-by: Stany MARCEL <stany.marcel@xxxxxxxxxxxxxxxxxxxxxx>

I am fine with it. Though I think you should also include the
actual compile error you get in the commit message.

Acked-by: Greg Ungerer <gerg@xxxxxxxxxxx>

Being a watchdog driver fix though it needs to also be sent to
the appropriate list and maintainer. get_mainatiner lists:

 Wim Van Sebroeck <wim@xxxxxxxxx> (maintainer:WATCHDOG DEVICE D...)
 linux-watchdog@xxxxxxxxxxxxxxx (open list:WATCHDOG DEVICE D...)
 linux-kernel@xxxxxxxxxxxxxxx (open list)

Regards
Greg


---

Changes:
  - V2: reword commit message.

  drivers/watchdog/m54xx_wdt.c |    1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/m54xx_wdt.c b/drivers/watchdog/m54xx_wdt.c
index 173494a..7466b4b 100644
--- a/drivers/watchdog/m54xx_wdt.c
+++ b/drivers/watchdog/m54xx_wdt.c
@@ -29,6 +29,7 @@
  #include <linux/bitops.h>
  #include <linux/ioport.h>
  #include <linux/uaccess.h>
+#include <linux/io.h>

  #include <asm/coldfire.h>
  #include <asm/m54xxsim.h>
--
1.7.9.5






--
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@xxxxxxxxxxxx
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux