Re: [PATCH v2] m68k: fix ColdFire clear cache operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Philippe,

On 12/07/12 01:51, Philippe De Muyter wrote:
On Wed, Jul 11, 2012 at 10:37:16AM +1000, gerg@xxxxxxxxxxxx wrote:

+	__asm__ __volatile__ (
+		"movec	%0,%%cacr\n\t"
+		"nop\n\t"

This could be written as

		"movec %0,%%cacr; nop"

It could, but IMHO that is not as clear. One instruction per line
is easier to read.


i.e. :
	final "\n\t" is useless

Yep, I will remove that.

Thanks
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@xxxxxxxxxxxx
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com


--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux