Re: [PATCH 2/2] net: add support for NS8390 based eth controllers on some ColdFire CPU boards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2012-07-04 at 09:52 +0200, Geert Uytterhoeven wrote:
On Wed, Jul 4, 2012 at 8:39 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
+static int mcf8390_init(struct net_device *dev)
+{
+  static u32 offsets[] = {
+          0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07,
+          0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f,
+  };

const?  u8?

That is assigned to the "reg_offset" field of "struct ei_device"
(defined in the existing 8390.h) and that is:

     u32 *reg_offset;         /* Register mapping table */

So I can't change this.

Sure you can, you can assign a u8 to a u32 just fine.

It's not the value that's assigned, but a pointer to the table, so
for now it must be non-const u32 *.

Oh, then of course you and Greg are correct.

It looks like the code in ax88796.c may actually
need u32 sizes too.


--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux