Hi Sarah, On Mon, Jun 11, 2012 at 10:17 PM, Sarah Nadi <snadi@xxxxxxxxxxxx> wrote:
Summary: Code block dead in ./arch/m68k/sun3/prom/init.c because file only gets compiled if CONFIG_SUN3 is enabled. Problem Description: Code block below in file ./arch/m68k/sun3/prom/init.c is only compiled if CONFIG_SUN3 is not enabled, while the file is compiled if CONFIG_SUN3 is enabled which means that this code block is dead. Seems that this block has always been around, and still exists in the latest release. In ./arch/m68k/Makefile: core-$(CONFIG_SUN3) += arch/m68k/sun3/ arch/m68k/sun3/prom/ In ./arch/m68k/sun3/prom/init.c : #ifndef CONFIG_SUN3 switch(romvec->pv_romvers) {
#endif Should this code be removed, or should the condition be changed?
Thanks! This code was copied from SPARC, but isn't relevant for the supported Sun-3 platforms. I'll remove it. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html