Re: [PATCH 8/11] Atari: add ISP16x host controller support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 6, 2012 at 10:13 AM, Michael Schmitz
<schmitzmic@xxxxxxxxxxxxxx> wrote:
+config ATARI_USB
+       bool "Atari USB host controller support"
+       depends on ATARI
+       select USB_SUPPORT
+       select USB_ARCH_HAS_HCD

Nothing actually uses CONFIG_ATARI_USB, it's just used to select USB_SUPPORT
and USB_ARCH_HAS_HCD?
Perhaps you can make the platform device creation depend on this?

I could select USB_ARCH_HAS_HCD conditional on USB_SUPPORT on Atari
without the need for an additional option, is that what you mean? I'm

Yes, or make USB_ARCH_HAS_HCD depend on ATARI, too, cfr. most other
architectures do.

not certain which way the selection works - do I get to select
USB_SUPPORT unconditionally?

Selecting USB_SUPPORT is not needed, as that question is asked during
configuration anyway.

But if you keep ATARI_USB, please keep on selecting USB_SUPPORT, else
the user has to enable both (you never want only one of ATARI_USB and
USB_SUPPORT anway).

Keeping ATARI_USB allows to put the creation of the platform devices
inside #ifdef CONFIG_ATARI_USB, which is IMHO a good idea as this
hardware is not "standard" but glued as an extension to the Atari CPU
bus.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux