Re: [PATCH 01/22] m68knommu: introduce macros to simplify ColdFire GPIO table initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Philippe,

On 04/26/2012 05:16 PM, Philippe De Muyter wrote:
Hi Greg,

On Thu, Apr 26, 2012 at 10:25:41AM +1000, gerg@xxxxxxxxxxxx wrote:
From: Greg Ungerer<gerg@xxxxxxxxxxx>

We have very large tables in the ColdFire CPU GPIO setup code that essentially
boil down to 2 distinct types of GPIO pin initiaization. Using 2 macros we can
reduce these large tables to at most a dozen lines of setup code, and in quite
a few cases a single table entry.

Introduce these 2 macros into the existing mcfgpio.h header.
...
+/*
+ *	Define macros to ease the pain of setting up the gpio tables.
+ */
+#define	MCFGPS(mlabel, mbase, mngpio, mpddr, mpodr, mppdr)		    \
...
+#define	MCFGPF(mlabel, mbase, mngpio)					    \
...

Maybe a small comment to explain when to use MCFGPS and when to use MCFGPF ?

Yep, that sounds like a good idea. I'll do that.

Thanks
Greg



------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@xxxxxxxxxxxx
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close,                            FAX:         +61 7 3891 3630
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux