Re: [PATCH] aufs: Do not refer to AUFS_NAME in pr_fmt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Thorsten Glaser:
This doesn=E2=80=99t really differ from what I sent last,
does it?

I am afraid you may not understand the important parts.
- the order of the definition and sched.h.
- no undef.


+#ifdef __KERNEL__

Hrm. Is this needed?

Indeed necessary since aufs_name.h is exported to userspace.


+#define pr_fmt(fmt)=09AUFS_NAME " %s:%d:%s[%d]: " fmt,\
+=09=09__func__, __LINE__, current->comm, current->pid

You need to #undef it first. It=E2=80=99s always defined, to just fmt.

No, I don't think undef is a good approach. The purpose of my patch, or
the difference from yours is to define pr_fmt first before all headers
including sched.h.


+#include <linux/aufs_name.h>

You include aufs_name.h twice now, once in the Makefile,
once in the header. Shouldn=E2=80=99t one be enough?

No, because aufs_type.h is exported to userspace.


J. R. Okajima
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux