Hi Geert,
On 12/26/2011 06:15 AM, Geert Uytterhoeven wrote:
On Fri, Dec 23, 2011 at 04:15,<gerg@xxxxxxxxxxxx> wrote:
From: Greg Ungerer<gerg@xxxxxxxxxxx>
The ColdFire CPU configurations need PAGE_OFFSET_RAW set to the base of
their RAM. It doesn't matter if they are running with the MMU enabled or
disabled, it is always set to the base of RAM.
We can keep the choices simple here and key of CONFIG_RAMBASE. If it is
defined we are on a plaftorm (ColdFire or other non-MMU systems) which
have a configurable RAM base, just use it.
Reported-by: Alexander Stein<alexander.stein@xxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Greg Ungerer<gerg@xxxxxxxxxxx>
Acked-by: Matt Waddel<mwaddel@xxxxxxxxx>
Acked-by: Kurt Mahan<kmahan@xxxxxxxxxxxx>
Acked-by: Geert Uytterhoeven<geert@xxxxxxxxxxxxxx>
but see below ...
-#ifdef CONFIG_MMU
-#ifndef CONFIG_SUN3
+#if defined(CONFIG_RAMBASE)
+#define PAGE_OFFSET_RAW CONFIG_RAMBASE
+#elif !defined(CONFIG_SUN3)
#define PAGE_OFFSET_RAW 0x00000000
#else
#define PAGE_OFFSET_RAW 0x0E000000
#endif
-#else
-#define PAGE_OFFSET_RAW CONFIG_RAMBASE
-#endif
To avoid alternating between defined and !defined, I'd suggest writing
it instead like:
#if defined(CONFIG_RAMBASE)
#define PAGE_OFFSET_RAW CONFIG_RAMBASE
#elif defined(CONFIG_SUN3)
#define PAGE_OFFSET_RAW 0x0E000000
#else
#define PAGE_OFFSET_RAW 0x00000000
#endif
Yep, absolutely, that is nicer. I'll change it to this.
Thanks
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@xxxxxxxxxxxx
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close, FAX: +61 7 3891 3630
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
