On Thu, 2011-11-17 at 22:05 +0100, Geert Uytterhoeven wrote:
Why do you care about SERIAL_CONSOLE? If it's only really used by
AMIGA_BUILTIN_SERIAL why shouldn't we rename it to
AMIGA_BUILTIN_SERIAL_CONSOLE?
Because SERIAL_CONSOLE is a universal platform-independent symbol.
Other arches have it as well (but less than in the past).
As soon as m68k gets a new serial driver, it will be used by 2 drivers again.
If one does
$ git grep -n "\<\(CONFIG_\)\?SERIAL_CONSOLE\>" | grep -v defconfig
one gets a few hits (summarized):
- arch/m68k/Kconfig.devices: discussed here;
- arch/sparc/Kconfig: apparently unused, and can be dropped;
- arch/xtensa/Kconfig and arch/xtensa/platforms/iss/console.c: the only
other current usage (note that the "S6105" platform, mentioned in the
Kconfig file, seems not to use it);
- drivers/staging/serial/68360serial.c: uses CONFIG_SERIAL_CONSOLE, but
I don't see how it can actually be set for that driver;
- drivers/tty/amiserial.c: discussed here.
I see nothing universal about it: two independent usages, one in
*/iss/console.c and one in */amiserial.c. So I'd say these can be
renamed to (say) ISS_SERIAL_CONSOLE and AMIGA_BUILTIN_SERIAL_CONSOLE.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
