On Sat, 10 Sep 2011, David Miller wrote:
From: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 11 Sep 2011 01:02:16 +1000 (EST)
Don't disable all interrupts, just disable the relevant one.
Also move a couple of printk calls outside of local_irq_save/restore.
Tested on a Quadra 660av.
Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
Using disable_irq() is very expensive, and when done from an interrupt
handler can deadlock especially on SMP (which I understand might not be
relevant here).
I really can't see why you'd do things this way, especially since
interrupt handlers under Linux now unconditionally always run with cpu
interrupts disabled.
I wasn't aware of this (I was under the impression that a higher priority
interrupt could be serviced). Please disregard this patch.
Finn
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
