On Sat, 2011-06-25 at 09:13 -0700, Ralf Baechle wrote:
On Sat, Jun 25, 2011 at 06:59:05AM -0700, Jeff Kirsher wrote:Move the MIPS drivers into drivers/net/ethernet/mips/ and make the necessary Kconfig and Makefile changes.NAck. sni_82596.c is a driver for the same chip but used in particular Siemens- Nixdorf systems. Lasi_82596 is an Intel NIC being used in PARISC systems. Not a good reason th throw PA-RISC drivers into the same directory after all PA-RISC has no relation to MIPS at all. So maybe they should go into drivers/net/ethernet/i82596 or drivers/net/ethernet/intel. And wherever they go, both drivers #include lib82596.c which your patch did not move around.
My bad, I had grouped these drivers because they both used lib82596.c and had thought I had moved that file as well.
Attachment:
signature.asc
Description: This is a digitally signed message part
