On Fri, Jun 17, 2011 at 19:22, Andreas Schwab <schwab@xxxxxxxxxxxxxx> wrote:
Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes:
This is the WARN_ONCE(!irqs_disabled()) check.
static inline bool arch_irqs_disabled_flags(unsigned long flags)
{
return (flags & ~ALLOWINT) != 0;
That should be
return (flags & 0x700) == 0x700;
It doesn't make sense to use ALLOWINT here, since arch_local_irq_disable
doesn't use it either.
Unfortunately this makes it worse:
| Calibrating delay loop... kernel BUG at kernel/posix-cpu-timers.c:1314!
BUG_ON(!irqs_disabled()) triggers as flags is 0x2619 there.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
