Hi Geert,
On 26/05/11 16:38, Geert Uytterhoeven wrote:
On Thu, May 26, 2011 at 08:23, Greg Ungerer<gerg@xxxxxxxxxxxx> wrote:
On 24/05/11 18:06, Andreas Schwab wrote:
Geert Uytterhoeven<geert@xxxxxxxxxxxxxx> áwrites:
What exactly do you mean by "does not support anything less"? It seems it
does
restrict instruction generation to 68000 if you ask for it.
The point is that Linux/m68k requires 68020+, so compiling for 68000
does not make sense (at least back when the gcc configuration was
created).
Yeah, used to be true :-)
This seems very much to me to be a "broken compiler" issue.
Is it worth putting some form of compiler version limits to protect
compilation in the m68000 case? á(Probably no need to limit it for
the existing 68020+ case).
Are there any other gcc defines that we could use instead?
We need to check with your old compiler Geert :-)
I really don't want to use CONFIG_MMU here (or in bitops.h either).
When I work in the ColdFire MMU code this won't be right.
I was more thinking along the lines of !CONFIG_M68000&& !CONFIG_M68010
&& !CONFIG_<whatever Coldfire that doesn't support it>.
Or in this case (and probably most cases) we could just switch
to using the same positive logic. So what I had as:
#if defined(__mc68020__) || defined(__mc68030__) || \
defined(__mc68040__) || defined(__mc68060__) || defined(__mcpu32__)
becomes
#if defined(CONFIG_M68020) || defined(CONFIG_M68030) || \
defined(CONFIG_M68040) || defined(CONFIG_M68060) || \
defined(CONFIG_MCPU32)
There currently isn't a CONFIG_MCPU32, but I could easily add
that (we only have one CPU in that class currently supported,
the 68360).
The compiler setting won't matter, only what we configured.
Sam will probably like this better, he suggested using the
kernel configs initially, in
http://www.spinics.net/lists/linux-m68k/msg03609.html
I will prepare some patches that do this and see how they look.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@xxxxxxxxxxxx
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
