Re: [PATCH] m68k/atari: Do not use "/" in interrupt names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 5, 2011 at 06:33, Michael Schmitz <schmitzmic@xxxxxxxxxxxxxx> wrote:
   error = request_irq(IRQ_MFP_ACIA, atari_keyboard_interrupt,
- Â Â Â Â Â Â Â Â Â Â Â Â IRQ_TYPE_SLOW, "keyboard/mouse/MIDI",
+ Â Â Â Â Â Â Â Â Â Â Â Â IRQ_TYPE_SLOW, "keyboard:mouse:MIDI",

The name is not a path, but an enumeration, so the slash should probably
be changed to a comma instead.

I thought about that, but comma (albeit followed by a space) is also used to
separate multiple interrupt handlers for shared interrupts.

What about '//', '|' or ':'?

Except for the atarilance one, these are sort of shared interrupt
handlers so maybe the comma won't hurt after all.

OK, I'll go for the comma.

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux