Re: [patch] m68k, mm: set all online nodes in N_NORMAL_MEMORY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 26, 2011 at 12:50, Thorsten Glaser <tg@xxxxxxxxx> wrote:
Michael Schmitz dixit:

   be done unconditionally since information about present memory has not
yet
   been recorded.
         ÂIf N_NORMAL_MEMORY is not accurate, slub may encounter
errors since it

Hrmâ

@@ -300,6 +300,8 @@ void __init paging_init(void)
       zones_size[ZONE_DMA] = m68k_memory[i].size >> PAGE_SHIFT;
       free_area_init_node(i, zones_size,
                 m68k_memory[i].addr >> PAGE_SHIFT, NULL);
+ Â Â Â Â Â Â Â Âif (node_present_pages(i))
+ Â Â Â Â Â Â Â Â Â Â Â Ânode_set_state(i, N_NORMAL_MEMORY);
   }
}

No, this has whitespace problems (tabs are expanded to spaces).

Fixed those up, applied, and will send to Linus for 2.6.39-final.

BTW, if I enable CONFIG_SLUB on my ARAnyM setup, I don't get a crash, but it
hangs after:

| INIT: version 2.86 booting

With Michael's patch, it continues fine.

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux