On 2010-11-15 16:27, Vivek Goyal wrote:
On Thu, Oct 28, 2010 at 02:42:23PM -0400, Vivek Goyal wrote:
Geert, my crosstool don't produce warning below. I guess this has to do
something with compiler version.
- Geert noticed following warning during compilation.
drivers/block/amiflop.c:1344: warning: ârqâ may be used uninitialized in
this function
drivers/block/ataflop.c:1402: warning: ârqâ may be used uninitialized in
this function
- Initialize rq to NULL to fix the warning. If we can't find a suitable request
to dispatch, this function should return NULL instead of a possibly garbage
pointer.
- Cross compile tested only. Don't have hardware to test it.
Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
Hi Jens,
Do you have any concerns about this patch? If not, can you please apply
it.
No, it's straight forward just got missed in travel. Applied, thanks.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
