Re: [PATCH] m68k: switch to using asm-generic/hardirq.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Geert,

On 20/09/10 02:32, Geert Uytterhoeven wrote:
On Tue, Sep 7, 2010 at 07:00, Greg Ungerer<gerg@xxxxxxxxxxxx>  wrote:

Hi All,

Is there any reason that the m68k arch cannot use the generic
hardirq.h support?

It looks to be the same, unless I am missing something.

Unfortunately it's not that simple: the m68k core doesn't use the
generic hardirq
code yet. Fixing header files it not enough.

Oh, yeah, I get that.

I did this based on visual inspection of the two files,
arch/m68k/include/asm/hardirq_mm.h and
include/asm-generic/hardirq.h.

They are almost the same (the irq_cpustat_t definition is identical).
Outside of a superfluous definition of ack_bad_irq the only difference
is the include of linux/irq.h. Is this enough to cause problems?


If it can then it is simple to merge the non-mmu and mmu
versions of hardirq.h.

yeah, one more reason to migrate to generic hardirqs...

Indeed :-)

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@xxxxxxxxxxxx
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux