Re: [PATCH] Macintosh: fix brace and trailing statement coding style issues in adb-iop.c This is a patch to the adb-iop.c file that cleans up brace and trailing statement warnings found by the checkpatch.pl tool. Signed-off-by: Michael Beardsworth <mbeards2@xxxxxxxxxxx>

[fthain@xxxxxxxxxxxxxxxxxxx]

> On Tue, Mar 09, 2010 at 01:46:20PM -0800, Michael Beardsworth wrote:

> > ...
> >  
> >  #ifdef DEBUG_ADB_IOP
> > -	printk("adb_iop_listen %p: rcvd packet, %d bytes: %02X %02X", req,
> > -		(uint) amsg->count + 2, (uint) amsg->flags, (uint) amsg->cmd);
> > +	printk(KERN_WARNING "adb_iop_listen %p: rcvd packet, %d bytes: %02X %02X",
> > +		req, (uint) amsg->count + 2, (uint) amsg->flags, (uint) amsg->cmd);
> >  	for (i = 0; i < amsg->count; i++)
> >  		printk(" %02X", (uint) amsg->data[i]);
> >  	printk("\n");

> > ...
> >  #ifdef DEBUG_ADB_IOP
> > -	printk("adb_iop_start %p: sending packet, %d bytes:", req, req->nbytes);
> > +	printk(KERN_WARNING "adb_iop_start %p: sending packet, %d bytes:", req, req->nbytes);
> >  	for (i = 0 ; i < req->nbytes ; i++)
> >  		printk(" %02X", (uint) req->data[i]);
> >  	printk("\n");

KERN_DEBUG is used for debugging messages, not KERN_WARNING.

Finn
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html