Re: [PATCH 1/1] tty: Mark generic_serial users as BROKEN

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 30, 2009 at 23:13, Greg Kroah-Hartman <gregkh@xxxxxxx> wrote:
From: Alan Cox <alan@xxxxxxxxxxxxxxx>

There isn't much else I can do with these. I can find no hardware for any
of them and no users. The code is broken.

Can you please also mention in the changelog what exactly is broken?

BTW, in response to your patch I received (private) email from people
who actually
have m68k MVME boards in active use. So marking it broken may be
called a regression...

Thanks!

Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
Cc: stable <stable@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
---
 arch/m68k/Kconfig    |    6 +++---
 drivers/char/Kconfig |    6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
index 29dd848..ecdc19a 100644
--- a/arch/m68k/Kconfig
+++ b/arch/m68k/Kconfig
@@ -561,7 +561,7 @@ config HPAPCI

 config MVME147_SCC
       bool "SCC support for MVME147 serial ports"
-       depends on MVME147
+       depends on MVME147 && BROKEN
       help
         This is the driver for the serial ports on the Motorola MVME147
         boards.  Everyone using one of these boards should say Y here.
@@ -576,14 +576,14 @@ config SERIAL167

 config MVME162_SCC
       bool "SCC support for MVME162 serial ports"
-       depends on MVME16x
+       depends on MVME16x && BROKEN
       help
         This is the driver for the serial ports on the Motorola MVME162 and
         172 boards.  Everyone using one of these boards should say Y here.

 config BVME6000_SCC
       bool "SCC support for BVME6000 serial ports"
-       depends on BVME6000
+       depends on BVME6000 && BROKEN
       help
         This is the driver for the serial ports on the BVME4000 and BVME6000
         boards from BVM Ltd.  Everyone using one of these boards should say
diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 08a6f50..6aad99e 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -323,7 +323,7 @@ config SPECIALIX

 config SX
       tristate "Specialix SX (and SI) card support"
-       depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA)
+       depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA) && BROKEN
       help
         This is a driver for the SX and SI multiport serial cards.
         Please read the file <file:Documentation/serial/sx.txt> for details.
@@ -334,7 +334,7 @@ config SX

 config RIO
       tristate "Specialix RIO system support"
-       depends on SERIAL_NONSTANDARD
+       depends on SERIAL_NONSTANDARD && BROKEN
       help
         This is a driver for the Specialix RIO, a smart serial card which
         drives an outboard box that can support up to 128 ports.  Product
@@ -395,7 +395,7 @@ config NOZOMI

 config A2232
       tristate "Commodore A2232 serial support (EXPERIMENTAL)"
-       depends on EXPERIMENTAL && ZORRO && BROKEN_ON_SMP
+       depends on EXPERIMENTAL && ZORRO && BROKEN
       ---help---
         This option supports the 2232 7-port serial card shipped with the
         Amiga 2000 and other Zorro-bus machines, dating from 1989.  At

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux