Christoph Hellwig <hch@xxxxxx> writes:
Hi Andreas,
On Mon, May 11, 2009 at 11:32:05AM +0200, Andreas Schwab wrote:
Looks good to me, except you also want to nix PTRACE_KILL from your switch
so the generic code handles it. Same goes for {PEEK,POKE}{DATA,TEXT} too.
Also note that you have to define a PTRACE_SINGLEBLOCK value in
asm/ptrace.h (new request code in your ptrace syscall ABI) to make
user_enable_block_step() get used by anything.
Thanks for your comments. I have made these changes and verified with
the ptrace testsuite that the singleblock request works correctly.
There are a few failures in the testsuite, which I haven't analyzed yet,
but none are regressions.
Any reason why this has never been commited?
Looks like Geert has a big backlog.
Andreas.
--
Andreas Schwab, schwab@xxxxxxxxxxxxxx
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html