On 14/06/09 02:15, Finn Thain wrote:
+++ ide-2.6/drivers/ide/ide-io.c
@@ -789,7 +789,8 @@ irqreturn_t ide_intr (int irq, void *dev
spin_lock_irqsave(&hwif->lock, flags);
- if (hwif->ack_intr && hwif->ack_intr(hwif) == 0)
+ if (hwif->port_ops && hwif->port_ops->test_irq &&
+ hwif->port_ops->test_irq(hwif) == 0)
Wouldn't that be
+ if (hwif->port_ops && hwif->port_ops->test_irq(hwif) &&
+ hwif->port_ops->clear_irq(hwif) == 0)
(this was never compiled?)
My bad.
(Note to self: don't try to quickly understand patches at 2am.)
case MAC_IDE_BABOON:
base = BABOON_BASE;
- ack_intr = NULL;
I think you mean:
case MAC_IDE_BABOON:
base = BABOON_BASE;
- ack_intr = NULL;
+ macide_port_ops.clear_irq = NULL;
Why is this broken into two patches? Bisecting in between doesn't work.
Same here.
Sorry for the noise.
Finn
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
