Re: [PATCH] mac8390: fix regression caused during net_device_ops conversion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Finn,

On Mon, May 25, 2009 at 17:36, Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
Changeset ca17584bf2ad1b1e37a5c0e4386728cc5fc9dabc broke mac8390 by adding
8390.o to the link. That meant that lib8390.c was included twice, once in
mac8390.c and once in 8390.c, subject to different macros. This patch
reverts that by avoiding the wrappers in 8390.c. They seem to be of no
value since COMPAT_NET_DEV_OPS is going away soon.

Tested with a Kinetics EtherPort card.

http://kisskb.ellerman.id.au/kisskb/buildresult/544582/
| drivers/built-in.o:(.rodata+0x1da6): undefined reference to `ei_poll'

Any chance this is related?

I cannot check it myself right now, as the power supply of my main
development machine blew up, taking down some vital motherboard components
with it.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux