[Resend, vger appears not to like other smtp server] On Tue, Dec 09, 2008 at 09:31:11AM +0100, Geert Uytterhoeven wrote:
I'm afraid my Amiga floppy drive doesn't work anymore... Any other testers available?
I still have a long unused Amiga around. However, it has not been graced with Linux yet, has no network device, the harddisk wasn't sounding very happy the last time I ran it those many years ago and that probably didn't improve. So I might be able to test it myself, but it would take time to set up.
--- a/drivers/block/amiflop.c +++ b/drivers/block/amiflop.c @@ -220,19 +218,17 @@ static irqreturn_t ms_isr(int irq, void *dummy) A more generic routine would do a schedule a la timer.device */ static void ms_delay(int ms) { - unsigned long flags; int ticks; + static DECLARE_MUTEX(mutex);^^^^^^^^^^^^^ Shouldn't this be a real mutex (declared using DEFINE_MUTEX(mutex)) instead of a semaphore used as a mutex?
Yes, it should be. I came back to Linux kernel development only in the recent months and totally missed these kind of locks. I'll prepare a new patch later. -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
